add storageID to gc manager #8684
Merged
+114
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadavsteindler
added
the
exclude-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
nadavsteindler
force-pushed
the
fix/support-storageid-in-garbagecollectionmanager
branch
from
0906d85 to
4423b73
Compare
nadavsteindler
commented
Feb 19, 2025
|
Note that there's another StorageID to handle, in |
nadavsteindler
force-pushed
the
fix/support-storageid-in-garbagecollectionmanager
branch
from
d88624b to
ecc4217
Compare
|
Manual testing is a success-- it identified the correct 33 files to delete in the S3 storage |
nadavsteindler
deleted the
fix/support-storageid-in-garbagecollectionmanager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8685
Change Description
Add StorageID to GarbageCollectionManager.
Testing
Can test with local lakefs + S3
See SGC acceptance tests repo generation here
Use the sparkless gc container- check that it identifies the correct commits
Run this flow for empty and non-empty storageID cases
lakefs:
access_key_id:
secret_access_key:
endpoint_url: http://localhost:8000/
objects_min_age: 1m